Text generation final touches #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
dacorvo
force-pushed
the
text_generation_final_touches
branch
2 times, most recently
from
7443a72
to
0b41acf
Compare
JingyaHuang
approved these changes
Jul 18, 2023
Instead of always providing default values for these parameters, we simply avoid passing them to the transformers model during export.
Co-authored-by: Jingya HUANG <[email protected]>
dacorvo
force-pushed
the
text_generation_final_touches
branch
from
d11834e
to
5360f26
Compare
JingyaHuang
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies a little the sequence of operations to better align on the transformers user experience, and adds the missing guide for generative models.