-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text generation final touches #141
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
7443a72
to
0b41acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, left some small nits!
Instead of always providing default values for these parameters, we simply avoid passing them to the transformers model during export.
Co-authored-by: Jingya HUANG <[email protected]>
d11834e
to
5360f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dacorvo !
This simplifies a little the sequence of operations to better align on the transformers user experience, and adds the missing guide for generative models.