Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text-to-video] Update modality #857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Text-to-video] Update modality #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tasks/src/pipelines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ export const PIPELINE_DATA = {
},
"text-to-video": {
name: "Text-to-Video",
modality: "cv",
modality: "multimodal",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in #477 as part of existing multimodal discussions in Slack (search for this PR). I'm happy to reconsider this specific case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, multimodal is anything that is not single modality

  • If only images are involved => cv
  • if only text is involed => nlp
  • if image + text, or any other combination of modalities (like text and video) => multimodal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image generation and captioning involve both text and images. I think the discussion had converged in cardinality of modalities of input or output. Please refer to the existing discussions

color: "green",
},
"image-text-to-text": {
Expand Down
Loading