♻️ Change library name: Adapter-Transformers -> Adapters #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you really want to update the library key, or is it fine to keep the old one? in case we want to change it, it'll be hackish, but i think we could code some kind of "redirect" for the library_name in our internal codebase 🤔 |
|
I think we can keep the old library key for now |
calpt
requested review from
osanseviero,
SBrandeis,
gary149 and
Wauplin
as code owners
julien-c
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated from
adapter-transformerslibrary to the newly released Adapters library. Related to huggingface/hub-docs#1184.Open Questions:
I haven't updated the library key from "adapter-transformers" as this is also the tag used on the hub. I'm not sure what the best way to handle this is? Should the tag stay the same, can we support both "adapters" and "adapter-transformers" or is it possible to automatically rename all tags?