Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate method() calls in GHContent class #1697

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: remove duplicate method() calls in GHContent class #1697

merged 1 commit into from
Aug 21, 2023

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Aug 18, 2023

Description

While reading the code, I saw those duplicate method().

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (9c00184) 80.10% compared to head (8493eda) 80.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1697      +/-   ##
============================================
- Coverage     80.10%   80.10%   -0.01%     
  Complexity     2237     2237              
============================================
  Files           215      215              
  Lines          6771     6769       -2     
  Branches        367      367              
============================================
- Hits           5424     5422       -2     
  Misses         1132     1132              
  Partials        215      215              
Files Changed Coverage Δ
src/main/java/org/kohsuke/github/GHContent.java 75.75% <100.00%> (-0.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit afb3477 into hub4j:main Aug 21, 2023
11 checks passed
@BoboTiG BoboTiG deleted the fix-duplicate-method-calls-ghcontent branch August 21, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants