Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance profiling of the Graph #77

Open
breznak opened this issue Jan 14, 2016 · 4 comments
Open

Performance profiling of the Graph #77

breznak opened this issue Jan 14, 2016 · 4 comments

Comments

@breznak
Copy link
Member

breznak commented Jan 14, 2016

Related to problem in #41

  1. on hotgym_full , garbage collection takes 49% time, can we reduce it?
  2. with strokeBorderWidth(=0.1) the function Dygraph.stroke._drawSeries() rampages from about 10sec/graph to 280sec/graph!
  3. highlightSeriesOpts also causing slowdown
  4. large graph loading too slow -- what are the steps, are we using chunking for that? may need to revert to a lower MAX_FILE_SIZE
@breznak
Copy link
Member Author

breznak commented Jan 14, 2016

ad 4) I fugured with "hide all" option, the graph renders much faster. Could be show the loading screen, keep loading (if not streaming) and Show All when reached end of file?

@jefffohl
Copy link
Member

I think that 60MB might be too large. That said, we can profile the different parts of the process.

@breznak
Copy link
Member Author

breznak commented Jan 14, 2016

Ok, we can try how reducing the size solves the issue.
Currently we resort to "Windowing" on large files, which is great for streaming data, but not ok if you want to work with the whole file, as in the hotgym_full.
What do you think about adding a toggle: Whole file (slow), Sliding window, Compressed, that would appear only if file>MAX_SIZE? Whole file & Windowing are implemented, Compressed would be idea of #43.

@jefffohl
Copy link
Member

That might be the solution. This ties into my thoughts about a revamped UX, where we perhaps have a step after the file has been checked, to ask the user how they would like the file to be processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants