add variable for advertised.host.name #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,11 @@ host.name={{kafka_listen_address}} | |||
| # Hostname the broker will advertise to producers and consumers. If not set, it uses the | |||
| # value for "host.name" if configured. Otherwise, it will use the value returned from | |||
| # java.net.InetAddress.getCanonicalHostName(). | |||
| {% if kafka_listen_address is defined %} | |||
There was a problem hiding this comment.
You have listen address in the if and advertised_host_name below.
|
Sorry about that, fixed now |
|
Looks good. The only other thing that sticks out to me is that this is useful enough to mention in the Readme, could you add it into the optional variables list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.