From 3466a76695dcfa61162b948aae07a095a65668e1 Mon Sep 17 00:00:00 2001
From: James McMullan <jpmcmu@gmail.com>
Date: Thu, 26 Sep 2024 21:51:34 -0400
Subject: [PATCH] Code review changes

---
 .../commons/ecl/RecordDefinitionTranslator.java          | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java b/commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java
index e63cef0c4..a0b0eedb3 100644
--- a/commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java
+++ b/commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java
@@ -55,6 +55,7 @@ public class RecordDefinitionTranslator
     final private static int    type_varunicode       = 33;
     final private static int    type_utf8             = 41;
 
+
     // FNoInitializer,                 // 0 means no initialiser - not a special virtual initialiser
     // FVirtualFilePosition,
     // FVirtualLocalFilePosition,
@@ -68,6 +69,8 @@ public class RecordDefinitionTranslator
     final private static int    type_char             = 11;         // Convert to string
     final private static int    type_qstring          = 30;         // Convert to string
 
+    final private static char   XPATH_DELIMITER       = 0x0001;
+
     // Additional retained flags
     final private static int    FLAG_IS_PAYLOAD_FIELD = 0x00010000;
 
@@ -762,13 +765,11 @@ private static int getJsonTypeDefinition(FieldDef field, HashMap<Integer, Intege
 
                     if (childField.getFieldType() == FieldType.DATASET)
                     {
-                        char delim = 0x0001;
-                        childJson.put("xpath", childField.getFieldName() + delim + "Row");
+                        childJson.put("xpath", childField.getFieldName() + XPATH_DELIMITER + "Row");
                     }
                     else if (childField.getFieldType() == FieldType.SET)
                     {
-                        char delim = 0x0001;
-                        childJson.put("xpath", childField.getFieldName() + delim + "Item");
+                        childJson.put("xpath", childField.getFieldName() + XPATH_DELIMITER + "Item");
                     }
 
                     fields.put(childJson);