Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of minor issues with IOR output #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjelmn
Copy link
Collaborator

@hjelmn hjelmn commented Jun 20, 2024

This commit fixes two issues:

  • The AIO backend prints the max outstanding transactions when starting. This is printed by every MPI rank and doesn't add much. Probably is left over from some debugging.

  • Init MPI before parsing the command line. Without this every rank thinks it is rank 0 so messages that should only be printed by rank 0 are printed n times.

This commit fixes two issues:

 - The AIO backend prints the max outstanding transactions when starting. This is printed by every MPI rank and doesn't add much. Probably is left over from some debugging.

 - Init MPI ***before*** parsing the command line. Without this every rank thinks it is rank 0 so messages that should only be printed by rank 0 are printed n times.

Signed-off-by: Nathan Hjelm <[email protected]>
@hjelmn hjelmn requested a review from JulianKunkel June 20, 2024 01:49
@hjelmn
Copy link
Collaborator Author

hjelmn commented Jun 20, 2024

Been a long time since I touched IOR but these two issues have been bugging me. Julian, PTAL.

@hjelmn
Copy link
Collaborator Author

hjelmn commented Jun 20, 2024

The only issue is the whole parse for -h before starting MPI thing. I can probably work around that if we want to maintain that. Honestly, starting MPI as a singleton is basically free so not a big deal.

@JulianKunkel
Copy link
Collaborator

The issue with -h is that there exist some MPI implementations that require a parallel job to be started before they can be initialized. Thus, it would not be possible to see the arguments of ior without running it in a parallel job.
This in turn might not be possible in an interactive way.
It is very annoying, therefore, I would not want to merge the "-h" behavior change.
An alternative might be that we have a "ior-help" tool or such without MPI, but it feels awkward. Any suggestions are welcome though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants