Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a large file hangs UI #32

Open
hmmwhatsthisdo opened this issue Jul 23, 2022 · 1 comment
Open

Selecting a large file hangs UI #32

hmmwhatsthisdo opened this issue Jul 23, 2022 · 1 comment

Comments

@hmmwhatsthisdo
Copy link

Selecting a large file in the file-picker (when sending a file) causes the UI to hang for some period of time. This appears to be roughly linear to the size of the file - a 400MB file hung the UI for 3 or 4 seconds, an 8gb one has hung the UI for well over a minute.

I'm not sure if the app is reading files into memory at the time they're selected for some reason, but I would imagine this isn't desired behavior in favor of streaming files into memory as they're sent.

@howeyc
Copy link
Owner

howeyc commented Jul 25, 2022

Yeah, it's basically copying the files into the app directory so I can pass files to the croc go library. The croc libary expects files that it can find/stat/open, but android just gives me an opaque byte reading stream.

It is something that I know should be possible to fix, but I would need to change a lot to be able to pass "readers" to croc and I haven't got around to it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants