Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Be consistent with BotKit api #14

Open
imjul1an opened this issue Feb 19, 2018 · 0 comments
Open

Be consistent with BotKit api #14

imjul1an opened this issue Feb 19, 2018 · 0 comments
Assignees

Comments

@imjul1an
Copy link

imjul1an commented Feb 19, 2018

By default, BotKit implements delete on local storage.users object https://github.com/howdyai/botkit/blob/master/lib/storage/simple_storage.js#L73

Botkit-starage-redis has a different implementation, https://github.com/howdyai/botkit-storage-redis/blob/master/src/index.js#L51. Instead of delete we have remove.

A proposal is to rename the remove function to delete function. But, in your case, it would make more sense to support both remove and delete for backward compatibility.

So it would be nice to keep an API consistent with the BotKit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants