Merge pull request #153 from horriblename/fix/segfault

fix: segfault
horriblename · Aug 25, 2024 · 427690a · 427690a
2 parents d0033c9 + 676e6df
commit 427690a
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/src/GestureManager.cpp b/src/GestureManager.cpp
@@ -272,7 +272,7 @@ void GestureManager::sendCancelEventsToWindows() {
 
     for (const auto& touch : this->touchedResources.all()) {
         const auto t = touch.lock();
-        if (t.impl_) { // FIXME: idk how to check weak pointer validity
+        if (t.get()) {
             t->sendCancel();
         }
     }
@@ -366,16 +366,23 @@ bool GestureManager::onTouchUp(ITouch::SUpEvent ev) {
     if (**SEND_CANCEL) {
         const auto surface = g_pInputManager->m_sTouchData.touchFocusSurface;
 
+        if (!surface.valid()) {
+            return true;
+        }
+
         wl_client* client = surface.get()->client();
-        if (client) {
-            SP<CWLSeatResource> seat = g_pSeatManager->seatResourceForClient(client);
+        if (!client) {
+            return true;
+        }
 
-            if (seat) {
-                auto touches = seat.get()->touches;
-                for (const auto& touch : touches) {
-                    this->touchedResources.remove(touch);
-                }
-            }
+        SP<CWLSeatResource> seat = g_pSeatManager->seatResourceForClient(client);
+        if (!seat.get()) {
+            return true;
+        }
+
+        auto touches = seat.get()->touches;
+        for (const auto& touch : touches) {
+            this->touchedResources.remove(touch);
         }
 
         return BLOCK;