Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oauth-providers] Problem with GitHub provider from version 0.5.0 #729

Open
geommr opened this issue Sep 6, 2024 · 1 comment
Open

[oauth-providers] Problem with GitHub provider from version 0.5.0 #729

geommr opened this issue Sep 6, 2024 · 1 comment

Comments

@geommr
Copy link

geommr commented Sep 6, 2024

starting from version 0.5.0 the redirect to callback no longer works on OAuth apps (returns HTTP 400 with body "Not found").
the getEmail refactor removes the this.oauthApp check, which is where I suspect the problem is -- v0.4.0 was working as expected.

Tested both on Hono v4.5.11.

I can open a PR if someone confirms this, repo can be found here for testing.
@yusukebe
Copy link
Member

Hi @geommr !

@monoald Can you handle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yusukebe @geommr