Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is defined as an announcement? #65

Closed
nerdfirefighter opened this issue Feb 17, 2018 · 3 comments
Closed

What is defined as an announcement? #65

nerdfirefighter opened this issue Feb 17, 2018 · 3 comments

Comments

@nerdfirefighter
Copy link
Contributor

Can we define which topics are considered announcements in the documentation?

This would be useful to understand what topics would be defined by the time the device state turns to ready.

My understanding is that when the state goes to ready, every node is defined along with all the properties to the level that we know what all the topics are.

@timpur
Copy link
Contributor

timpur commented Feb 17, 2018

TBH that's also my assumption.

Any reason this shouldn't be the case. I believe all discovery messages should be sent before ready is set. Some messages will come after, like stats. But yes I might go through them and marks the ones defined latter after ready or something like that.

@euphi euphi added the bug label Apr 1, 2018
@euphi
Copy link
Member

euphi commented Apr 1, 2018

I tagged this as "bug", because the convention is not clear enough regarding this.
(However, we already defined the various states in the new convention, so it is not an enhancement).

@ThomDietrich
Copy link
Collaborator

Imho this is related to #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants