-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebridge-appletv-enhanced #666
Comments
✅ Pre-checks completed successfully. |
Issues that relate to this request: |
Hi @maxileith your readme states the plugin only works on linux and (maybe) mac - ok. i don't have a windows to test, but what happens if a windows user tries to install this plugin? at what point does it not work? |
npm won't allow a windows user to install the plugin. In the package.json is specified that the only allowed operating systems are MacOS and Linux. https://docs.npmjs.com/cli/v10/configuring-npm/package-json#os |
And from the issues raised on GitHub I can tell that actually pretty many users are using MacOS. The issues that were raised by MacOS users in the past were mostly non Mac-specific. So I assume that it runs fine (the raised issues have of course been fixed). But I do not have a Mac to test ... |
In fact I had just been looking at that |
It refuses to install. E.g., when setting the
Of course, in the homebridge-appletv-enhanced package it is the other way around ( |
Comment
|
Just checking on this one, your plugin only creates new files in the Homebridge storage directory right? it doesn't make any changes to file outside of this? |
That is correct. This is why I was raising homebridge/homebridge-apt-pkg#16 in the first place. |
Congratulations! Your plugin has been verified. You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! Thank you for your contribution to the Homebridge Community. |
Nice idea with the venv for python! |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
If updating your |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
If updating your |
Hi @bwp91. I just wanted to retrigger the check to see if my plugin is still compliant or if I have to comply to new requirements regarding verification. However, I do not really understand the error above as my repo definitely does have a package.json. |
/check |
🔴 The following checks failed:
🟢 The following checks passed:
If updating your |
Link To GitHub Repo
https://github.com/maxileith/homebridge-appletv-enhanced
Link To NPM Package
https://www.npmjs.com/package/homebridge-appletv-enhanced
Plugin Icon (Optional)
No response
The text was updated successfully, but these errors were encountered: