Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-yokis-http-client #578

Closed
mutaben opened this issue Oct 13, 2023 · 3 comments
Closed

homebridge-yokis-http-client #578

mutaben opened this issue Oct 13, 2023 · 3 comments
Labels
awaiting-user-reply use after review has started - awaiting user to reply to a comment

Comments

@mutaben
Copy link

mutaben commented Oct 13, 2023

Link To GitHub Repo

https://github.com/justarandomdev/homebridge-yokis-http-client

Link To NPM Package

https://www.npmjs.com/package/homebridge-yokis-http-client

@mutaben mutaben added the pending the label given to a new verification/icon request label Oct 13, 2023
@github-actions
Copy link

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Oct 25, 2023

Hi @JustARandomDev

With a simple config of

        {
            "username": "hjk",
            "password": "hjk",
            "platform": "YokisHTTPClient"
        }

my log is absolutely spammed with a full axios error every 10 seconds. In this case great that the error is caught and doesnt trash the process, but perhaps just the error message could be posted to the log?

Could it be made so that if the response is for an incorrect username/password combination, then the plugin simply stops, since config changes would need a restart anyway?

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed pending the label given to a new verification/icon request labels Oct 27, 2023
@bwp91
Copy link
Contributor

bwp91 commented Nov 18, 2023

Closing due to no response, feel free to reopen if verification is still wanted 😁

@bwp91 bwp91 closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-reply use after review has started - awaiting user to reply to a comment
Projects
None yet
Development

No branches or pull requests

2 participants