-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebridge-RedAlertViaKumta #577
Comments
✅ Pre-checks completed successfully. |
Hi verification team, Would appreciate fast handling, This plugin is used to getting emergency alerts on rockets for Israel citizens. thank you very much Keep safe 🇮🇱 |
Please fix the issue where a user has clicked Save on the settings ui without entering any info, which leads to a config of:
and leads to a homebridge restart:
I would also update the node version in the package json to also support node 20, as many users will now be updating to this. from
to
There are a couple of other requests too, I'll post these in a follow up comment! |
Also if incorrect info is supplied in the config, it leads to a crash loop too
One of the requirements of verification is that plugin errors are caught and nicely logged to the homebridge log rather than being unhandled and terminating/restarting the node process. |
Got it. Will commit a new fixed version by tomorrow. |
Given the nature of this plugin (I think is a first for Homebridge, so I discussed this with the team!): We would like to see some form of disclaimer (1) on the plugin readme and (2) on the plugin settings screen (ideally in hebrew and english) just calling out that the plugin should be used along with the main source of notifications - in this case telegram. We would not like to have a situation where a user is 100% reliant on this plugin - and let's say another plugin is causing homebridge to restart without the user knowing - and so the user never receives a homebridge notification in a critical case. Many users may assume that 'homebridge verified' means 'definitely works'. Since I personally cannot test that the plugin works (but also not trying to insinuate that it doesn't). We just want users to continue to still rely on the telegram notifications, but use this homebridge plugin as a helpful extra. In an ideal world we should never need a plugin like this in the first place. |
Will be handled as well, fully understood, |
please reply on here when a new version is ready with the above changes and i'll get to it as soon as i can 😃 |
Hi @bwp91 , done. Hopefully everything is working and written as expected Thank you very much 🙏 |
Hi @bwp91 Thanks |
/check |
✅ Pre-checks completed successfully. |
Everything Looks Good! |
Congratulations! Your plugin has been verified. You can now add the Verified by Homebridge badge to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! Thank you for your contribution to the Homebridge Community. |
You should add some keywords in the package json file so that users can search for the plugin better in the UI |
Also, thanks for making the changes and the disclaimer. Very happy to verify this plugin. One last thing I would like to request in the case of this plugin, is that if the alert systems that the plugin uses ever stop working permanently (ie are closed down) then it would also be important to reflect this in the disclaimer and plugin readme! |
Hi, We will handle all stuff mentioned here tomorrow morning and will release new version. Thank you all verification team 🙏🇮🇱⚔️ |
Link To GitHub Repo
https://github.com/DanZBo/homebridge-RedAlertViaKumta
Link To NPM Package
https://www.npmjs.com/package/homebridge-red-alert-via-kumta
The text was updated successfully, but these errors were encountered: