Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-panasonic-cloud-platform #576

Closed
sdamasoc opened this issue Oct 8, 2023 · 12 comments
Closed

homebridge-panasonic-cloud-platform #576

sdamasoc opened this issue Oct 8, 2023 · 12 comments
Labels
awaiting-user-reply use after review has started - awaiting user to reply to a comment

Comments

@sdamasoc
Copy link

sdamasoc commented Oct 8, 2023

Link To GitHub Repo

https://github.com/sdamasoc/homebridge-panasonic-ac-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-panasonic-cloud-platform

@sdamasoc sdamasoc added the pending the label given to a new verification/icon request label Oct 8, 2023
@sdamasoc
Copy link
Author

sdamasoc commented Oct 8, 2023

Existing homebridge-panasonic-ac-platform was not maintained anymore. I forked the repo and I am trying to maintain it up-to-date

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

✅ Pre-checks completed successfully.

@Mani1082
Copy link

Mani1082 commented Oct 8, 2023

Nice, thanks for taking the continuity

@jandersonhill
Copy link

A huge thank you to @mkz212 for providing fixes and @sdamasoc for maintaining this homebridge plugin for Panasonic ac units

@M0rT4L13
Copy link

M0rT4L13 commented Oct 8, 2023

Existing homebridge-panasonic-ac-platform was not maintained anymore. I forked the repo and I am trying to maintain it up-to-date

A W E S O M E ! Thank you so much. Works well !

@blackcodefr
Copy link

Great. Can't wait for the updated repo.

@jandersonhill
Copy link

It'll be great to have this on the list verified homebridge plugins

@embee8
Copy link

embee8 commented Oct 8, 2023

Existing homebridge-panasonic-ac-platform was not maintained anymore. I forked the repo and I am trying to maintain it up-to-date

See here for figuring out ownership of the original plugin. Sticking with the established project structure would help avoid fragmentation. If that is the desired option, you might want to merge the fork back into the project and maintain it from there.

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed pending the label given to a new verification/icon request labels Oct 11, 2023
@bwp91
Copy link
Contributor

bwp91 commented Oct 12, 2023

Hi @sdamasoc given the replies on

do we still need to look into verification for the plugin mentioned in your request on here?

@jandersonhill
Copy link

@bwp91 I think we should request the homebridge-panasonic-ac-platform project is Homebridge verified. The changes made here (along with other fixes) have now been pulled into the main project.

@embee8
Copy link

embee8 commented Oct 12, 2023

@jandersonhill, happy to say that we already got it verified back in 2021, see #369.

@jandersonhill
Copy link

@embee8 My bad, I must have checked an out-of-date list of verified plugins. Clearly, still learning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-reply use after review has started - awaiting user to reply to a comment
Projects
None yet
Development

No branches or pull requests

7 participants