From bf7f5554c8ce4ce647d53558708cee74c306685b Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Wed, 19 Jul 2023 15:44:40 -0400 Subject: [PATCH 1/3] Add Node.js_v18 Dependency --- INFO.sh | 1 + repo/index.js | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/INFO.sh b/INFO.sh index 9620eb0..2b574f8 100755 --- a/INFO.sh +++ b/INFO.sh @@ -17,6 +17,7 @@ silent_upgrade="no" adminprotocol="http" adminurl="" adminport="8581" +install_dep_packages="Node.js_v18" displayname="Homebridge" description="Homebridge on Synology DSM." diff --git a/repo/index.js b/repo/index.js index b09afc1..e599466 100644 --- a/repo/index.js +++ b/repo/index.js @@ -32,7 +32,6 @@ const path = require('path'); version: version, dname: 'Homebridge', desc: 'Homebridge on Synology DSM.', - install_dep_packages: 'Node.js_v18', price: 0, download_count: 56691, recent_download_count: 1138, From e0482e4a9c410cfaf31766c98420af35c34befac Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Thu, 20 Jul 2023 13:05:00 -0400 Subject: [PATCH 2/3] Fixes --- README.md | 4 ++-- app/source.sh | 18 ++++++++---------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 5cb1b39..61a4be6 100644 --- a/README.md +++ b/README.md @@ -12,8 +12,8 @@ This third-party Synology Package simplifies the process of running [Homebridge] ## Supported Models -* **x86_64** - All 64 bit Intel / AMD CPU Models -* **evansport** (i686) - DS214play, DS414play, DS415play +* **x86_64** - All 64 bit Intel / AMD CPU Models ( braswell ) +* **evansport** (i686) - DS214play, DS414play, DS415play ( evansport ) * **rtd1296** (armv8) - DS420j, DS220j, RS819, DS418, DS218, DS218play, DS118 * **armada37xx** (armv8) - DS120j, DS119j * **armada38x** (armv7) - DS419slim, DS218j, RS217, RS816, DS416j, DS416slim, DS216, DS216j, DS116 diff --git a/app/source.sh b/app/source.sh index 58b2f00..cb95424 100755 --- a/app/source.sh +++ b/app/source.sh @@ -1,17 +1,15 @@ #!/bin/sh - - export HB_SERVICE_STORAGE_PATH="$(readlink -f /var/packages/homebridge/shares/homebridge)" +NODE_BIN_PATH="/var/packages/homebridge/target/app/bin" # Use Synology supplied NodeJS v18 - https://github.com/homebridge/homebridge-syno-spk/issues/124 -# if [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then -NODE_BIN_PATH="/var/packages/Node.js_v18/target/usr/local/bin" -export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v18/target/usr/local/bin/node" -# else -# NODE_BIN_PATH="/var/packages/homebridge/target/app/bin" -# export HB_SERVICE_NODE_EXEC_PATH="/var/packages/homebridge/target/app/bin/node" -#fi +if [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then + NODE_BIN_PATH="/var/packages/Node.js_v18/target/usr/local/bin:$NODE_BIN_PATH" + export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v18/target/usr/local/bin/node" +else + export HB_SERVICE_NODE_EXEC_PATH="/var/packages/homebridge/target/app/bin/node" +fi export HB_SERVICE_EXEC_PATH="/var/packages/homebridge/target/app/lib/node_modules/homebridge-config-ui-x/dist/bin/hb-service.js" @@ -57,4 +55,4 @@ export HOMEBRIDGE_SYNOLOGY_PACKAGE=1 export UIX_CUSTOM_PLUGIN_PATH="$HB_SERVICE_STORAGE_PATH/node_modules" export UIX_BASE_PATH_OVERRIDE="/var/packages/homebridge/target/app/lib/node_modules/homebridge-config-ui-x" export UIX_USE_PNPM=0 -export UIX_USE_PLUGIN_BUNDLES=1 +export UIX_USE_PLUGIN_BUNDLES=1 \ No newline at end of file From 6fef5dee67b67f61a0bc64646acaeeea2589846e Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Thu, 20 Jul 2023 13:07:53 -0400 Subject: [PATCH 3/3] Wording --- .github/workflows/main.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7e278c7..0cb9b25 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -46,6 +46,10 @@ jobs: This package will deploy Homebridge and the Homebridge UI natively on your Synology NAS. It will create a new shared named `homebridge` to store the Homebridge configuration and user data. + #### Dependencies + + This package will leverage the Synology supplied NodeJS v18 package. + #### Add the Homebridge Synology Package Source: 1. Open Package Center in DSM and select the `Settings` option.