Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brighter text in menus etc. #10

Open
andriej opened this issue Nov 24, 2019 · 6 comments
Open

Brighter text in menus etc. #10

andriej opened this issue Nov 24, 2019 · 6 comments
Assignees
@lance36

Comments

@andriej
Copy link

andriej commented Nov 24, 2019

At least on my AMOLED screen, the dark gray is too.. dark to be easily seen (i.e. panel items or texts of menus).
It would be nice to see it light-gray IMHO.

Thanks for the theme.
@maartenpaauw
Copy link
Contributor

@lance36, maybe we can make it lighter? How are others feeling about this?

@lance36
Copy link
Collaborator

lance36 commented Dec 9, 2019

Yes, you are right. it is a tad too dark on some screens.
I saw the issue but just haven't had time to work on it. I'm sorry. Will take a look in the weekend.

@fourtrax01
Copy link

Especially in the states page of the dev tools the gray on gray is unreadable
Capture

lance36 added a commit that referenced this issue Dec 26, 2019
@lance36
Brighter text in menus, darker tables
7c06bf6 
should take care of #10
@lance36 lance36 mentioned this issue Dec 26, 2019
Merged
lance36 added a commit that referenced this issue Dec 27, 2019
@lance36
Card background is now properly true black.
133619a 
A much needed commit.

Update amoled.yaml

chore(deps): bump yamllint from 1.19.0 to 1.20.0

Bumps [yamllint](https://github.com/adrienverge/yamllint) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/adrienverge/yamllint/releases)
- [Changelog](https://github.com/adrienverge/yamllint/blob/master/CHANGELOG.rst)
- [Commits](adrienverge/yamllint@v1.19.0...v1.20.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Brighter text in menus, darker tables

should take care of #10

Update amoled.yaml
@fourtrax01
Copy link

fourtrax01 commented Jan 10, 2020 •
edited
Loading

The states page is still unusable can you make the entity text lighter like the color of all the rest of the text at the top? Needs more contrast. It is a little better than before but he text is still too dark to be read.

@maartenpaauw
Copy link
Contributor

@fourtrax01, feel free to submit a PR 😄

@lance36
Copy link
Collaborator

lance36 commented Apr 13, 2020

Unfortunately from what i could find this is a widespread problem with dark themes as HomeAssistant uses --primary-color instead of --text-primary-color for href elements

home-assistant/frontend#3412

@maartenpaauw maartenpaauw mentioned this issue May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance36 lance36

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lance36 @maartenpaauw @andriej @fourtrax01