-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add duckdb support #1398
add duckdb support #1398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 88.73% 88.94% +0.20%
==========================================
Files 51 52 +1
Lines 7592 7751 +159
==========================================
+ Hits 6737 6894 +157
- Misses 855 857 +2 ☔ View full report in Codecov by Sentry. |
Is the long term goal to implement a real duckdb backend for more efficient usage? |
Can you elaborate on This PR doesn't change the converter at all; only patches duckdb so DuckDBPyRelation.hvplot() is available. It does not do |
Yes. Is the plan to implement a real HoloViz backend such that you only query the data needed for the plot? For example when using |
I'm not sure I follow; this PR allows hvplot off of a DuckDBRelation, which is already the result of a query. connection > relation (select * from table where ...) > hvplot
Ah I see the confusion:
Can be drilled down further
|
Was slightly mistaken, but a little modification works: Not sure if we should manually add the optimization to subset x/y columns (e.g. |
Oh I guess it is converting to pandas object first: Edit: Now it does what you proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
01fe825
to
6abcb7d
Compare
Okay I think this is ready. I added the diagrams + added changes from #1359 |
Co-authored-by: Maxime Liquet <[email protected]>
Co-authored-by: Simon Høxbro Hansen <[email protected]>
Closes #1397