Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param 2 and HoloViews 1.18 compatibility #1164

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Param 2 and HoloViews 1.18 compatibility #1164

merged 5 commits into from
Oct 6, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 5, 2023

No description provided.

@@ -24,6 +24,7 @@
hv_version = Version(hv.__version__)
bokeh_version = Version(bokeh.__version__)
bokeh3 = bokeh_version >= Version("3.0")
param2 = Version(param.__version__) >= Version("2.0rc4")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted a rc version high enough.

rc should be removed at some point

@hoxbro hoxbro changed the title Param 2 compatibility Param 2 compatibility and Matplotlib pin Oct 5, 2023
@hoxbro
Copy link
Member Author

hoxbro commented Oct 5, 2023

Matplotlib pin should be removed when holoviz/holoviews#5924 and holoviz/holoviews#5910 are merged, and a dev release it out.

They will be in the next Holoviews release.

Edit: Do not seem to be the problem see holoviz/holoviews#5925

[skip ci]
@hoxbro hoxbro changed the title Param 2 compatibility and Matplotlib pin Param 2 compatibility Oct 6, 2023
@hoxbro hoxbro changed the title Param 2 compatibility Param 2 and HoloViews 1.18 compatibility Oct 6, 2023
@hoxbro
Copy link
Member Author

hoxbro commented Oct 6, 2023

Need to dive deeper into where the dict problem is located. For this HoloViews dev release, I ignore the failing notebooks, which is not ideal.

@hoxbro hoxbro merged commit 69d19a2 into main Oct 6, 2023
@hoxbro hoxbro deleted the param2_comp branch October 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant