Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert geo + rasterize changes introduced in 1135 #1163

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 4, 2023

Fixes #1162

The changes made in #1135 were already possible with project=True.

@hoxbro hoxbro changed the title Geo + rasterize problems. Geo + rasterize problems Oct 4, 2023
@hoxbro hoxbro marked this pull request as draft October 4, 2023 16:19
@hoxbro hoxbro changed the title Geo + rasterize problems Revert geo + rasterize changes introduced in 1135 Oct 5, 2023
@hoxbro hoxbro force-pushed the geo_datashader branch 2 times, most recently from a3e64a8 to eac2ce9 Compare October 5, 2023 07:03
@hoxbro
Copy link
Member Author

hoxbro commented Oct 5, 2023

Okay, reverting most of the changes in #1135 related to gv.project, as they were already possible with the setting project=True.

@hoxbro
Copy link
Member Author

hoxbro commented Oct 5, 2023

@ahuang11, can you take a look at this PR? If you see weird behavior with geo + rasterize stuff, try to enable project=True.

@hoxbro hoxbro marked this pull request as ready for review October 5, 2023 07:18
@maximlt maximlt requested a review from ahuang11 October 5, 2023 15:46
@hoxbro hoxbro merged commit 0a798c8 into main Oct 6, 2023
7 checks passed
@hoxbro hoxbro deleted the geo_datashader branch October 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rasterized and projected RGB plot very slow or hanging
3 participants