-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support plots that use by
with rasterize
with hv.ImageStack
#1132
Conversation
by
with rasterize
plots for ImageStack
by
with rasterize
plots for ImageStackby
with rasterize
with hv.ImageStack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the code (with holoviz/holoviews#5751), I get the following plot. I suspect some custom handling of the hover tool is needed.
Just noting, we need to open an issue to record that this needs to be documented when HoloViews is released with the new feature this PR depends on. |
I am confused, what needs to be documented? |
Sorry for the lack of context. |
|
I have left a comment in the holoviews issue about the hover tool. I'm also a bit surprised that the colorbar stops at 0.8. |
Co-authored-by: Simon Høxbro Hansen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is ready, you can merge it.
@@ -194,6 +195,11 @@ def test_datashade_rescale_discrete_levels_default_True(self): | |||
actual = plot.callback.inputs[0].callback.operation.p['rescale_discrete_levels'] | |||
assert actual is expected | |||
|
|||
def test_rasterize_by(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also have a version check, but let us ignore it if all tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep for us it works well but sometimes distros that re-package our tools complain about this kind of stuff (and probably just patch things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll add a check in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* WIP overlaying rasterized * Clean up * Add rasterize to check for categorical * Add test * Add version check * Update hvplot/converter.py Co-authored-by: Simon Høxbro Hansen <[email protected]> --------- Co-authored-by: Simon Høxbro Hansen <[email protected]>
Alongside holoviz/holoviews#5751
colorbar is not yet supported in HoloViews.