Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use x/ylims as datashader operations' x/yranges #1126

Closed
wants to merge 1 commit into from
Closed

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Aug 9, 2023

Closes #1120

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, but I'm surprised we weren't always doing this!

@ahuang11
Copy link
Collaborator Author

Actually I think we might already be doing this here so this PR is not necessary.
https://github.com/holoviz/hvplot/blob/main/hvplot/converter.py#L1303-L1306
cc @philippjfr

@ahuang11 ahuang11 closed this Aug 22, 2023
@maximlt maximlt deleted the lims_to_ranges branch January 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvplot setting xlim/ylim should first sel data when rasterize=True/datashade=True
2 participants