Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore phpunit.xml #27

Open
sprankhub opened this issue Sep 6, 2021 · 0 comments
Open

gitignore phpunit.xml #27

sprankhub opened this issue Sep 6, 2021 · 0 comments

Comments

@sprankhub
Copy link

phpunit.xml is usually environment-specific, so that I think it should be gitignored. Magento itself has it under gitignore as well. You currently have it in your .gitignore file, but since this file is not mapped at

"map": [
[
"etc",
"dev/tests/quick-integration/etc"
],
[
"framework",
"dev/tests/quick-integration/framework"
],
[
"phpunit.xml.dist",
"dev/tests/quick-integration/phpunit.xml.dist"
],
[
"README.md",
"dev/tests/quick-integration/README.md"
]
],
, the file will not be gitignored under dev/tests/quick-integration/. Is this on purpose or should we map the .gitignore file as well?

Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant