From a7c0fa680f3df107f588d79371a3c36554454d93 Mon Sep 17 00:00:00 2001 From: Hans Nieser Date: Tue, 26 Oct 2021 12:06:12 +0200 Subject: [PATCH 1/4] fix: run pecl from PHPDIR, avoid build asking for input --- install.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/install.sh b/install.sh index 4b9f8e9..9b98fce 100644 --- a/install.sh +++ b/install.sh @@ -138,7 +138,8 @@ install_php() { sed -i '' "s/^listen = 127.0.0.1:$PHPFPM/listen = 127.0.0.1:$XPHPFPM/g" /usr/local/etc/php/"$PHPVERSION"/php-fpm-xdebug.d/www.conf echo "Installing Imagick for PHP" - pecl install imagick + # We pipe `yes ''` into pecl, as imagick asks for input during compilation and would otherwise get stuck. + yes '' | $PHPDIR/bin/pecl install imagick echo "[$PHP] ✅ Installed" echo "" From eef3db13578dbee04d2cce0f1243a7cb19463b17 Mon Sep 17 00:00:00 2001 From: Hans Nieser Date: Tue, 26 Oct 2021 12:06:53 +0200 Subject: [PATCH 2/4] fix: do upgrade (which always does the right thing) instead of install --- install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.sh b/install.sh index 9b98fce..66a30c5 100644 --- a/install.sh +++ b/install.sh @@ -139,7 +139,7 @@ install_php() { echo "Installing Imagick for PHP" # We pipe `yes ''` into pecl, as imagick asks for input during compilation and would otherwise get stuck. - yes '' | $PHPDIR/bin/pecl install imagick + yes '' | $PHPDIR/bin/pecl upgrade imagick echo "[$PHP] ✅ Installed" echo "" From 067fa1187191dd3bc4b98619a642d88f5fd83323 Mon Sep 17 00:00:00 2001 From: Hans Nieser Date: Tue, 26 Oct 2021 12:12:15 +0200 Subject: [PATCH 3/4] fix: grep more specifically for our own services --- install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.sh b/install.sh index 66a30c5..5e11f8a 100644 --- a/install.sh +++ b/install.sh @@ -265,7 +265,7 @@ If everything went well the 'err' column should be 0. You can now see these proc pid err name " -launchctl list | grep reach +launchctl list | grep reachdigital echo " 🎉 Done" From a692a55937d2c6c75e836db212d91a80fe1badaf Mon Sep 17 00:00:00 2001 From: Hans Nieser Date: Tue, 26 Oct 2021 12:18:17 +0200 Subject: [PATCH 4/4] docs: add note regarding PHP 7.2 linking issue workaround --- install.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/install.sh b/install.sh index 5e11f8a..541b740 100644 --- a/install.sh +++ b/install.sh @@ -263,6 +263,9 @@ done echo " If everything went well the 'err' column should be 0. You can now see these processes in activity monitor. 🎉 +In case the PHP 7.2 services failed to start, this may be due to a known issue, refer to the README for a possible +workaround. + pid err name " launchctl list | grep reachdigital