Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display API errors to the user #35

Open
cecilia-donnelly opened this issue Jul 14, 2016 · 2 comments
Open

Display API errors to the user #35

cecilia-donnelly opened this issue Jul 14, 2016 · 2 comments

Comments

@cecilia-donnelly
Copy link

Now that the API returns human-readable errors if the data submitted was incorrect (e.g. birthday in the future), we should display those errors to the user of this client. Currently if the save fails the user doesn't get any notification -- the app just redirects back to the Search page.
cecilia-donnelly pushed a commit that referenced this issue Jul 14, 2016
Authenticate to the API
f9bfc2b 
Pass the id_token with requests to the API, so we can retrieve
information and update clients.  Note that we're not showing anything to
the user that indicates to them whether or not their request to update a
user was successful (see #35).

Next, don't show the search screen until the user has logged in.
cecilia-donnelly referenced this issue Jul 21, 2016
Display API errors to the user
581e4d2 
Show API errors to the user to avoid mysterious failures.  This is still
behaving badly in Chromium; looking into that next.
@cecilia-donnelly
Copy link
Author

See 581e4d2.

@cecilia-donnelly
Copy link
Author

While the API errors are technically readable by a human, they're not really friendly enough for the client app. Instead of "A parameter value was invalid.: SSN must match the pattern ^[0-9xX]{9}$," for example, we should say something like, "This SSN has the wrong number of characters" or "Don't include - in SSNs."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cecilia-donnelly