Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache predicate regex #610

Open
MicaiahReid opened this issue Jul 1, 2024 · 0 comments
Open

Cache predicate regex #610

MicaiahReid opened this issue Jul 1, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@MicaiahReid
Copy link
Contributor

Our print_event predicate allows regex to be used to match print events. We currently take an input string and evaluate it as regex in a loop, which is expensive.

In our data validation step for a predicate, we are already casting once - we should just cache that value on the predicate to avoid recomputing.

@MicaiahReid MicaiahReid added the good first issue Good for newcomers label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant