Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visual studio support? c++? easy setup for idiots like me? the "instructions" are too vague #21

Open
ghost opened this issue Aug 9, 2020 · 3 comments
Open

visual studio support? c++? easy setup for idiots like me? the "instructions" are too vague #21

ghost opened this issue Aug 9, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 9, 2020 •
edited by ghost
Loading

how can i use this with a normal visual studio project? and how does it actually work? will i never need to ever wait for anything to compile? is there an "idiot proof" guide on how to set this up with a c++ project on the latest version of visual studio?

i don't feel like this is very approachable currently, and i wanted an easy to setup option, the insanely long compile times are driving me a bit insane, i'm a very "learn by trial and error" kinda guy so if i could waste less time waiting around and doing more stuff i would get more done

i pretty much would love if you could just, install this stuff and just use visual studio as you normally would, i hope the setup process isn't too finnicky since i'm not a fan of having to deal with extra crap, but i could make a sacrifice for the sake of time saving
@ghost ghost changed the title visual studio support? c++? visual studio support? c++? easy setup for idiots like me? Aug 9, 2020
@ghost
Copy link
Author

ghost commented Aug 9, 2020

i come from here and i have no idea how to use this
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1609r3.html

@ghost
Copy link
Author

ghost commented Aug 9, 2020 •
edited by ghost
Loading

i guess i need to figure out, how to "tie" clangjit to visual studio? but what am i supposed to do with the files? i have no idea, i don't know how to do anything with this and it's kinda frustrating

build as you would Clang/LLVM for your system

this is so vague, i have no idea what that means, there are no instructions or anything, just this really vague statement

"do it like you would" is not very helpful

i feel like 99% of instructions on the internet are written by people who already know what they are doing, and they leave out all the details needed to actually set anything up if you are just starting from scratch, and to me it always felt pretty unfair, i always make sure to document and explain everything i do, it helps me personally and it helped others in the past

@ghost ghost changed the title visual studio support? c++? easy setup for idiots like me? visual studio support? c++? easy setup for idiots like me? te "instructions" are too vague Aug 9, 2020
@ghost ghost changed the title visual studio support? c++? easy setup for idiots like me? te "instructions" are too vague visual studio support? c++? easy setup for idiots like me? the "instructions" are too vague Aug 9, 2020
@tapika
Copy link

tapika commented Oct 4, 2020

Suspect I've raised same issue as you: #22

But yes, instructions are bit small indeed - but if they do not use Windows - how can they produce instructions for Windows ?

dutiona pushed a commit to dutiona/llvm-project-cxxjit that referenced this issue Dec 21, 2023
@DimitryAndric @zmodem
Instantiate Error in Target::GetEntryPointAddress() only when necessary
6406b6f 
When `Target::GetEntryPointAddress()` calls `exe_module->GetObjectFile()->GetEntryPointAddress()`, and the returned
`entry_addr` is valid, it can immediately be returned.

However, just before that, an `llvm::Error` value has been setup, but in this case it is not consumed before returning, like is done further below in the function.

In https://bugs.freebsd.org/248745 we got a bug report for this, where a very simple test case aborts and dumps core:

```
* thread hfinkel#1, name = 'testcase', stop reason = breakpoint 1.1
    frame #0: 0x00000000002018d4 testcase`main(argc=1, argv=0x00007fffffffea18) at testcase.c:3:5
   1	int main(int argc, char *argv[])
   2	{
-> 3	    return 0;
   4	}
(lldb) p argc
Program aborted due to an unhandled Error:
Error value was Success. (Note: Success values must still be checked prior to being destroyed).

Thread 1 received signal SIGABRT, Aborted.
thr_kill () at thr_kill.S:3
3	thr_kill.S: No such file or directory.
(gdb) bt
#0  thr_kill () at thr_kill.S:3
hfinkel#1  0x00000008049a0004 in __raise (s=6) at /usr/src/lib/libc/gen/raise.c:52
hfinkel#2  0x0000000804916229 in abort () at /usr/src/lib/libc/stdlib/abort.c:67
hfinkel#3  0x000000000451b5f5 in fatalUncheckedError () at /usr/src/contrib/llvm-project/llvm/lib/Support/Error.cpp:112
hfinkel#4  0x00000000019cf008 in GetEntryPointAddress () at /usr/src/contrib/llvm-project/llvm/include/llvm/Support/Error.h:267
hfinkel#5  0x0000000001bccbd8 in ConstructorSetup () at /usr/src/contrib/llvm-project/lldb/source/Target/ThreadPlanCallFunction.cpp:67
hfinkel#6  0x0000000001bcd2c0 in ThreadPlanCallFunction () at /usr/src/contrib/llvm-project/lldb/source/Target/ThreadPlanCallFunction.cpp:114
hfinkel#7  0x00000000020076d4 in InferiorCallMmap () at /usr/src/contrib/llvm-project/lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:97
hfinkel#8  0x0000000001f4be33 in DoAllocateMemory () at /usr/src/contrib/llvm-project/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:604
hfinkel#9  0x0000000001fe51b9 in AllocatePage () at /usr/src/contrib/llvm-project/lldb/source/Target/Memory.cpp:347
hfinkel#10 0x0000000001fe5385 in AllocateMemory () at /usr/src/contrib/llvm-project/lldb/source/Target/Memory.cpp:383
hfinkel#11 0x0000000001974da2 in AllocateMemory () at /usr/src/contrib/llvm-project/lldb/source/Target/Process.cpp:2301
hfinkel#12 CanJIT () at /usr/src/contrib/llvm-project/lldb/source/Target/Process.cpp:2331
hfinkel#13 0x0000000001a1bf3d in Evaluate () at /usr/src/contrib/llvm-project/lldb/source/Expression/UserExpression.cpp:190
hfinkel#14 0x00000000019ce7a2 in EvaluateExpression () at /usr/src/contrib/llvm-project/lldb/source/Target/Target.cpp:2372
hfinkel#15 0x0000000001ad784c in EvaluateExpression () at /usr/src/contrib/llvm-project/lldb/source/Commands/CommandObjectExpression.cpp:414
hfinkel#16 0x0000000001ad86ae in DoExecute () at /usr/src/contrib/llvm-project/lldb/source/Commands/CommandObjectExpression.cpp:646
hfinkel#17 0x0000000001a5e3ed in Execute () at /usr/src/contrib/llvm-project/lldb/source/Interpreter/CommandObject.cpp:1003
hfinkel#18 0x0000000001a6c4a3 in HandleCommand () at /usr/src/contrib/llvm-project/lldb/source/Interpreter/CommandInterpreter.cpp:1762
hfinkel#19 0x0000000001a6f98c in IOHandlerInputComplete () at /usr/src/contrib/llvm-project/lldb/source/Interpreter/CommandInterpreter.cpp:2760
hfinkel#20 0x0000000001a90b08 in Run () at /usr/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:548
hfinkel#21 0x00000000019a6c6a in ExecuteIOHandlers () at /usr/src/contrib/llvm-project/lldb/source/Core/Debugger.cpp:903
hfinkel#22 0x0000000001a70337 in RunCommandInterpreter () at /usr/src/contrib/llvm-project/lldb/source/Interpreter/CommandInterpreter.cpp:2946
hfinkel#23 0x0000000001d9d812 in RunCommandInterpreter () at /usr/src/contrib/llvm-project/lldb/source/API/SBDebugger.cpp:1169
hfinkel#24 0x0000000001918be8 in MainLoop () at /usr/src/contrib/llvm-project/lldb/tools/driver/Driver.cpp:675
hfinkel#25 0x000000000191a114 in main () at /usr/src/contrib/llvm-project/lldb/tools/driver/Driver.cpp:890```

Fix the incorrect error catch by only instantiating an `Error` object if it is necessary.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D86355

(cherry picked from commit 1ce07cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tapika