Stomps all over the local keymap if outline-minor-mode is enabled (or disabled)

[phil-s]

(add-hook 'outline-minor-mode-hook 'mediawiki-outline-magic-keys) is really bad.

mediawiki-outline-magic-keys calls local-set-key for a bunch of key sequences. That's usually the major mode keymap, which is shared amongst all buffers in that mode whether or not outline-minor-mode (let alone mediawiki-mode) is enabled in any given buffer, and which persists for future buffers using that major mode as well.

And because the global outline-minor-mode-hook was used, this clobbering happens again in future, even if you'd re-bound the keys manually, until you figure out what was causing it.

And this all happens from simply loading mediawiki.el.

I suggest creating a new buffer-local minor mode for the desired key bindings, and then only enabling that mode in the specific buffers where you want it.

[hexmode]

Excellent points. I'll look at fixing this soon.

[hexmode]

Could you see if this is fixed in the latest master?

[phil-s]

No, the current master is commit 05aab5c and we can see that nothing has changed:

mediawiki-el/mediawiki.el

Lines 1917 to 1932 in 05aab5c

	(defun mediawiki-outline-magic-keys ()
	"Set up outline magic keys.
	See https://www.emacswiki.org/emacs/OutlineMagic"
	(interactive)
	(unless (featurep 'xemacs)
	(local-set-key [(shift iso-lefttab)] 'outline-cycle)
	(local-set-key [iso-left-tab] 'outline-cycle))
	(local-set-key [(meta left)] 'outline-promote)
	(local-set-key [(meta right)] 'outline-demote)
	(local-set-key [(shift return)] 'newline-and-indent)
	(local-set-key [(control left)] 'mediawiki-simple-outline-promote)
	(local-set-key [(control right)] 'mediawiki-simple-outline-demote)
	(local-set-key [(control up)] 'outline-move-subtree-up)
	(local-set-key [(control down)] 'outline-move-subtree-down))
	(add-hook 'mediawiki-mode-hook (lambda () (outline-minor-mode nil)))
	(add-hook 'outline-minor-mode-hook 'mediawiki-outline-magic-keys)

[hexmode]

ah, thanks for showing me.

[aspiers]

Ouch, this is really bad. It just bit me by breaking outshine-mode, and confused the hell out of me until I traced it to this package. I suggest simply removing that add-hook line as a quick fix, but yeah, these keys absolutely must be moved to their own map. In the mean time I'm going to have to uninstall this package unfortunately.