Initial implementation #3

edmorley · 2023-02-03T14:25:01Z

The initial implementation of a native (non-shimmed) libcnb.rs-based Python CNB.

See:

Project overview (internal)
GUS epics/work report (internal)
Work that is out of scope for the initial version: https://github.com/heroku/buildpacks-python/issues
Upstream Cloud Native Buildpacks information:
- https://buildpacks.io/docs/
- https://github.com/buildpacks/spec/blob/main/buildpack.md
libcnb.rs documentation
Prior art:
- https://github.com/heroku/heroku-buildpack-python (the classic Heroku Python buildpack)
- Other libcnb.rs-based Heroku CNBs

Since cargo already treats them as semver version ranges (so this is effectively a no-op), and this way it avoids conflicts/churn in this file from Dependabot PRs.

Since the vast majority do not need a changelog entry.

Since with the new beta Docker for macOS Rosetta feature the build times on M1 have significantly improved.

Since it's testing an implementation detail of the functions runtime and/or Pip, which isn't helpful to test in this buildpack.

Since we cache the pip cache only instead.

Since `ubuntu-latest` and `ubuntu-22.04` are now equivalent, since their rollout of the change in default image version has now completed.

So it fits in the sidebar

- Split them out into separate files - Import them into the crate so private APIs can be used Inspired by: https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html http://xion.io/post/code/rust-unit-test-placement.html https://doc.rust-lang.org/reference/items/modules.html#the-path-attribute

Malax

The README could use some work, but this can easily be added later. That said, I think this is the new gold-standard for a Heroku languages-team CNB! I love the code, documentation and tests and wish my buildpack would look like this. It was a pleasure reviewing this! Awesome work dude! ✋🏻

I left a couple of nitpicky comments, but none are blocking at all.

tests/integration/python_version.rs

tests/integration/pip.rs

tests/integration/python_version.rs

src/python_version.rs

src/packaging_tool_versions.rs

Taken from: https://github.com/heroku/buildpacks-ruby/blob/d988c4371cc5aef11e1c7375fad4f7ed87475de8/.github/workflows/release.yml#L69-L75

src/packaging_tool_versions.rs

schneems

I'm still working on finishing my review, but wanted to leave my pending comments.

src/utils.rs

src/package_manager.rs

src/main.rs

src/layers/python.rs

src/layers/pip_cache.rs

src/layers/pip_dependencies.rs

src/layers/python.rs

src/main.rs

edmorley

@schneems Thank you for taking the time to review! :-)

src/layers/pip_cache.rs

src/layers/pip_dependencies.rs

src/layers/python.rs

src/main.rs

src/layers/python.rs

src/main.rs

src/package_manager.rs

src/utils.rs

joshwlewis

Looks awesome!

.github/workflows/ci.yml

src/package_manager.rs

src/utils.rs

Co-authored-by: Josh W Lewis <[email protected]>

All comments resolved

edmorley added 30 commits December 9, 2022 22:40

Functions MVP

719f105

Install salesforce-functions from PyPI now it's been published

d87a78d

Fix CI after salesforce-functions 0.2.0 release

4e5ba1e

Bump minimum Rust version to 1.66

fca044c

Only use major versions in Cargo.toml

406f255

Since cargo already treats them as semver version ranges (so this is effectively a no-op), and this way it avoids conflicts/churn in this file from Dependabot PRs.

Skip check changelog for Dependabot PRs

f687559

Since the vast majority do not need a changelog entry.

Refresh lockfile

35a6dde

Remove support for skipping check-changelog using the PR description

11efc72

Update buildpacks/github-actions to 5.0.1

f518418

Remove workarounds for slow M1 performance

cc2fb09

Since with the new beta Docker for macOS Rosetta feature the build times on M1 have significantly improved.

Refresh Cargo.lock

d0ed798

Update test after salesforce-functions v0.3.0 release

fb848be

Remove functions integration test for too-old Python

a4abc3f

Since it's testing an implementation detail of the functions runtime and/or Pip, which isn't helpful to test in this buildpack.

Remove caching support from the pip layer

40aa0af

Since we cache the pip cache only instead.

Add VSCode configs

2abc573

Bump minimum Rust version to 1.67

ef88b80

Refresh Cargo.lock

1be9dc4

Switch Dependabot to monthly

42343e3

Switch GitHub Action runner image back to ubuntu-latest

3489dc5

Since `ubuntu-latest` and `ubuntu-22.04` are now equivalent, since their rollout of the change in default image version has now completed.

Remove now-unused test fixture

eb98a86

Pass detect for non-functions too

47d06d5

Update to pip 23.0, setuptools 67.0.0, wheel 0.38.4

76c2822

Clean up functions handling

da42891

More unit tests, rustdocs and comments

1ac2ec6

Switch buildpack ID back to heroku/python

448921e

Test heroku/buildpacks:20 in CI too

92046bb

Shorten CI job name

6c32581

So it fits in the sidebar

Update Cargo dependencies

d849fae

Update to setuptools 67.1.0

f85f39d

Remove notes.md

bbe592d

edmorley added 2 commits February 24, 2023 14:48

Update Swatinem/rust-cache to v2.2.1

fa4b16e

Improve cache and logging

457a017

edmorley marked this pull request as ready for review February 24, 2023 16:10

edmorley added 4 commits February 27, 2023 11:56

Refactor Python runtime archive URL generation

583b04f

Update dependencies

2a92049

Refactor PackagingToolVersions

9bc83dd

More rustdocs

9048996

edmorley requested a review from a team February 28, 2023 10:12

edmorley added 2 commits February 28, 2023 10:22

Add work item numbers to some of the TODOs

ff1c62c

Malax approved these changes Mar 1, 2023

View reviewed changes

edmorley added 4 commits March 1, 2023 10:44

Misc cleanup

f22600c

Address review comments

b189360

Add a release script

e95f00e

Add duplicate version check to release workflow

630d74f

Taken from: https://github.com/heroku/buildpacks-ruby/blob/d988c4371cc5aef11e1c7375fad4f7ed87475de8/.github/workflows/release.yml#L69-L75

merwok reviewed Mar 1, 2023

View reviewed changes

src/packaging_tool_versions.rs Outdated Show resolved Hide resolved

merwok reviewed Mar 1, 2023

View reviewed changes

src/packaging_tool_versions.rs Show resolved Hide resolved

schneems previously requested changes Mar 2, 2023

View reviewed changes

edmorley commented Mar 3, 2023

View reviewed changes

Fix comment typo

7dce0d5

joshwlewis approved these changes Mar 4, 2023

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

src/package_manager.rs Outdated Show resolved Hide resolved

src/utils.rs Show resolved Hide resolved

edmorley and others added 2 commits March 6, 2023 10:52

Clarify comment about env var inheritance

1922305

Fix comment typo in package_manager.rs

55349e4

Co-authored-by: Josh W Lewis <[email protected]>

edmorley added 2 commits March 6, 2023 11:22

Update to setuptools 67.5.0

b2b796f

Refresh Cargo.lock

dd390e9

edmorley enabled auto-merge (squash) March 6, 2023 11:29

edmorley merged commit 11270fc into main Mar 6, 2023

edmorley deleted the initial-implementation branch March 6, 2023 11:32

schneems mentioned this pull request Mar 7, 2023

Finish review on initial implementation #15

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation #3

Initial implementation #3

edmorley commented Feb 3, 2023 •

edited

Loading

Malax left a comment

schneems left a comment

edmorley left a comment

joshwlewis left a comment

Initial implementation #3

Initial implementation #3

Conversation

edmorley commented Feb 3, 2023 • edited Loading

Malax left a comment

Choose a reason for hiding this comment

schneems left a comment

Choose a reason for hiding this comment

edmorley left a comment

Choose a reason for hiding this comment

joshwlewis left a comment

Choose a reason for hiding this comment

edmorley commented Feb 3, 2023 •

edited

Loading