-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imprecision in XRA #622
Comments
I don't get the EDIT part of the comment. Where in the code we should compute the transitive closure? |
In the |
method |
No, that one is correct. I believe it only is called when doing the active set computation. |
I noticed that on EBR, XRA under
imm.cat
produces a smaller may-set forrf
than under other memory models.After some debugging, I found the source of this discrepancy. After reducing it to its core, I found this
There are only two conclusions: Either our XRA handling of acyclicity axioms is imprecise
or propagation through transitive closures is somehow wrong.EDIT: After quickly checking the code, I found that XRA for acyclicity axioms is indeed imprecise because it avoids the computation of the transitive must-closure. Now that we have must rf-edges between threads, it might be worth to compute the transitive closure.
The text was updated successfully, but these errors were encountered: