[asl] Check type validity on user input #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
force-pushed
the
asl-valid-types
branch
from
1d08b68
to
de28a50
Compare
HadrienRenaud
force-pushed
the
asl-valid-types
branch
7 times, most recently
from
dd2b712
to
9f4ec0e
Compare
HadrienRenaud
force-pushed
the
asl-valid-types
branch
5 times, most recently
from
6c14b99
to
46092e0
Compare
HadrienRenaud
force-pushed
the
asl-valid-types
branch
from
46092e0
to
407a4ad
Compare
2 tasks
HadrienRenaud
force-pushed
the
asl-valid-types
branch
4 times, most recently
from
5b00cbe
to
dce6f0d
Compare
HadrienRenaud
force-pushed
the
asl-valid-types
branch
5 times, most recently
from
9ea8851
to
47421db
Compare
|
Hello, @maranget do you have any objection to merging this PR? |
This was referenced Apr 15, 2024
|
thanks @HadrienRenaud please do go ahead. |
This implied an important rework on parameter handling.
HadrienRenaud
force-pushed
the
asl-valid-types
branch
from
47421db
to
1244bb8
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at checking type-validity on every user-provided type.