Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new XOR token to reflect change in LRM #761

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

Roman-Manevich
Copy link
Collaborator

@Roman-Manevich Roman-Manevich commented Jan 22, 2024

Added a new keyword "XOR", which is mapped to the token EOR.

Added a new test.

Test plan:

asllib/tests/ASLTypingReference.t$ aslref --no-exec --type-check-strict TypingRule.CheckBinOp.asl
$ dune runtest asllib
$ make test-aarch64-asl
$ make test

"11.1.27 Exclusive-OR operator
The name of the exclusive-OR operator is now XOR."
Both "EOR" and "XOR" are mapped to the same token --- EOR.
This does mean that our scanner accepts both keywords, regardless of the
version of the language passed to aslref, but it's probably not a big
deal.
When the move to ASLv1 is complete, we can move "EOR" to the reserved
keyword list.

Added a new test.
Copy link
Collaborator

@HadrienRenaud HadrienRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Roman-Manevich

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file is not quoted in ASLTypingReference.tex, should we keep it in ASLTypingReference.t? Or should it go in asl.t? (until it is renamed by #757 into regressions.t)

Or maybe your plan @Roman-Manevich is to quote it in a subsequent PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to add it to ASLTypingReference.tex

@Roman-Manevich Roman-Manevich merged commit 5586dfe into master Jan 22, 2024
@Roman-Manevich Roman-Manevich deleted the asl-xor branch January 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants