Added new XOR token to reflect change in LRM #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"11.1.27 Exclusive-OR operator The name of the exclusive-OR operator is now XOR." Both "EOR" and "XOR" are mapped to the same token --- EOR. This does mean that our scanner accepts both keywords, regardless of the version of the language passed to aslref, but it's probably not a big deal. When the move to ASLv1 is complete, we can move "EOR" to the reserved keyword list. Added a new test.
HadrienRenaud
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
If this file is not quoted in ASLTypingReference.tex, should we keep it in ASLTypingReference.t? Or should it go in asl.t? (until it is renamed by #757 into regressions.t)
Or maybe your plan @Roman-Manevich is to quote it in a subsequent PR?
There was a problem hiding this comment.
I intend to add it to ASLTypingReference.tex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new keyword "XOR", which is mapped to the token EOR.
Added a new test.
Test plan:
asllib/tests/ASLTypingReference.t$ aslref --no-exec --type-check-strict TypingRule.CheckBinOp.asl
$ dune runtest asllib
$ make test-aarch64-asl
$ make test