Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"5ms" are not 0.05s #102

Open
BenWiederhake opened this issue Aug 6, 2020 · 2 comments
Open

"5ms" are not 0.05s #102

BenWiederhake opened this issue Aug 6, 2020 · 2 comments

Comments

@BenWiederhake
Copy link

https://github.com/hephaest0s/usbkill/blob/master/usbkill/usbkill.py#L140

1 millisecond is 0.001 seconds. Therefore, 5 milliseconds is 0.005 seconds.

I propose changing the comment, because 50 milliseconds is still quick enough.

dieantu added a commit to dieantu/usbkill that referenced this issue Aug 29, 2022
5 milliseconds is 0.005 seconds as said in hephaest0s#102. Thankyou!
@ghost
Copy link

ghost commented Jun 29, 2023

On my fork of USBKill, https://github.com/Dreadysa/usbkill-revived/ I have fixed this issue. This project is essentially dead, you will need to rely on forks.

@ghost
Copy link

ghost commented Jul 26, 2023

I am back under a different name because of a PII leak in my repo. I have also fixed this again on my usbkill-revived project.

I foolishly used my installation of USBKill for the code, I am using the code from this repo to modify instead on my new repo. PII leaks shouldn't happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant