Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing quote in HIP-18 #306

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix missing quote in HIP-18 #306

merged 2 commits into from
Nov 6, 2024

Conversation

yardenshoham
Copy link
Contributor

Just added a missing quote

Just added a missing quote

Signed-off-by: Yarden Shoham <[email protected]>
@gjenkins8
Copy link
Contributor

(DCO status has been lost, but changes here are obviously acceptable)

@yardenshoham
Copy link
Contributor Author

Want me to push again?

@gjenkins8
Copy link
Contributor

yes please!

@yardenshoham
Copy link
Contributor Author

Done

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattfarina mattfarina merged commit a21f739 into helm:main Nov 6, 2024
1 check passed
@yardenshoham yardenshoham deleted the patch-1 branch November 7, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants