BetterKV still hits a lot of KV.get

[lavrton]

Hello. I have several questions, all of them around one issue. So I am using BetterKV and I noticed that I don't see much reduction in KV read usage.

Question about line:

FlareUtils/src/BetterKV/index.ts

Line 148 in b223d82

Date.now() - created - this.config.cacheTtl,

Isn't there an issue in ms vs secs metrics? cacheTtl is in secs, right? Looks like it will make Math.random() < probability always true, which will lead to reading from cache.

Here shouldn't we try to use expirationTtl from options when we set a key/value?

FlareUtils/src/BetterKV/index.ts

Line 344 in b223d82

"cloudflare-cdn-cache-control": `max-age=${this.config.cacheTtl}`,

[helloimalastair]

@lavrton how is this for your first issue?

As for the second thing, while it would be more efficient, I don't think it actually hurts anything to cache longer, since we check for expiration with the probability check anyway?