New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first pass, suppress daily question if user had no timeline #1769

Open

jykfan wants to merge 5 commits into master from jyfan/question-suppress-daily

Contributor

jykfan commented Sep 14, 2016

Feature for https://hello.slack.com/archives/research/p1473578206000033 cc @benejoseph
Expected behavior, if user does not have valid timeline last night, we suppress the "how was your sleep last night" question, but do not suppress other questions types: goal reflection, survey, demographics

@kingshyg would you mind reviewing?

needs update in suripu-app
aside: with regards to the QuestionProcessor method getUserAnsweredQuestionIds - what's the reasoning behind removing newbie inserted questions if the askTime is before today?

jykfan added 5 commits

September 13, 2016 17:57


          first pass, suppress daily question if user had no timeline

691db8e


          pass in todayLocal instead of today

decdbba


          format datetime string with datetimeutil

778e91e


          pass tests

4300c29


          add comment

38afdab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet