Soft disable Service Provider promotions #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
force-pushed
the
mj/revert-referral-partially
branch
2 times, most recently
from
2faa21d
to
72ab216
Compare
michaeldjeffrey
requested review from
andymck,
jeffgrunewald,
macpie and
bbalser
and removed request for
andymck
macpie
approved these changes
Oct 8, 2024
bbalser
approved these changes
Oct 8, 2024
michaeldjeffrey
force-pushed
the
mj/revert-referral-partially
branch
from
bed36b1
to
21c6669
Compare
In it's current form service provider promotions is not being released yet. This is all the code that deals with promotion rewards in a mobile reward share.
- do not write sp allocations to reward manifest. - always return nothing from the database when asking for promotion rewards These two things will effectively keep promotion rewards from being released. The Service Provider Reward calculations will continue as planned thinking there are no promotio rewards to give out.
michaeldjeffrey
force-pushed
the
mj/revert-referral-partially
branch
from
21c6669
to
e1edd67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto PR
The groundwork for Service Provider promotions is fine. Some of the finer details are still in flux.
This PR is disabling any part of service provider promotions that might be written to a public file that would lock us into those proto versions.