Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of HIP-131 #858

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Implementation of HIP-131 #858

merged 12 commits into from
Sep 4, 2024

Conversation

bbalser
Copy link
Contributor

@bbalser bbalser commented Aug 28, 2024

https://github.com/helium/HIP/blob/main/0131-bridging-gap-between-verification-mappers-and-anti-gaming-measures.md

New Ban_type(PoC) is added and is radio is is banned with type PoC then all assignment_multipliers for it are set to 0.0.

Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -76,7 +77,9 @@ pub(crate) fn clean_covered_hexes(

// hip-103: if a hex is boosted by a service provider >=1x, the oracle
// multiplier will automatically be 1x, regardless of boosted_hex_status.
let assignment_multiplier = if ranked.boosted.is_some() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above comment needs an update

@michaeldjeffrey
Copy link
Contributor

SpBoostedRewardsBannedRadioBanType::BoostedHex maps directly to SPBoostedRewardEligibility::ServiceProviderBanned.

SpBoostedRewardsBannedRadioBanType::Poc appears equivalent to not processing the radio for points at all.

If HIP-131 was more than a stop-gap measure for another HIP, I would like to see it integrated into the calculator as more than a boolean.

But it does introduce the concept of a boosted hex restriction applying to oracle boosting, whereas it was only service provider boosting before. It could be a nice idea to extend coverage_point_calculator::BoostedHexStatus to include restriction statuses on oracle boosting.

@bbalser bbalser merged commit 2d6bd03 into main Sep 4, 2024
17 checks passed
@bbalser bbalser deleted the bbalser/hip-125-extended branch September 4, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants