Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-125 #835

Merged
merged 23 commits into from
Jul 9, 2024
Merged

HIP-125 #835

merged 23 commits into from
Jul 9, 2024

Conversation

bbalser
Copy link
Contributor

@bbalser bbalser commented Jun 27, 2024 •
edited
Loading

@bbalser bbalser marked this pull request as ready for review July 2, 2024 17:27
michaeldjeffrey
michaeldjeffrey approved these changes Jul 5, 2024
View reviewed changes
coverage_point_calculator/src/lib.rs Outdated Show resolved Hide resolved
ingest/src/server_mobile.rs Show resolved Hide resolved
andymck
andymck reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a first pass looks good other than a couple of naming convention nits. Will take another pass

file_store/src/file_info.rs Outdated
@@ -209,6 +212,8 @@ pub enum FileType {
InvalidatedRadioThresholdReq,
InvalidatedRadioThresholdIngestReport,
VerifiedInvalidatedRadioThresholdIngestReport,
ServiceProviderBoostedRewardsBannedRadioIngestReport,
VerifiedServiceProviderBoostedRewardsBannedRadioIngestReport,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above drop ServiceProvider in favour of SP?

coverage_point_calculator/src/lib.rs Show resolved Hide resolved
bbalser added 20 commits July 9, 2024 14:43
@bbalser
Update mobile ingest to support sp_boosted_rewards_ban_radio messages
e179a25
@bbalser
Start to sp boosted rewards ban ingestor
de6b64c
@bbalser
make clippy happy
3645a37
@bbalser
Simplify structs and add verified file sink
00b56e9
@bbalser
Add cleanup task to remove old data from db table
a45e673
@bbalser
Update mobile-verifier rewarder to incorporate sp bans
a44a23f
@bbalser
Refactoring
7df6285
@bbalser
move seniority logic to own module
e62fd44
@bbalser
refactoring seniority update
68ba942
@bbalser
reset radio seniority when receiving a service provider ban
43053a6
@bbalser
remove deprecated modeled coverage start date
8b395f4
@bbalser
Fixing bugs adding tests
6949a11
@bbalser
Add test for updating seniority
2c19e9b
@bbalser
remove commented out code
691b5e7
@bbalser
Addressing feedback
a21ed78
@bbalser
Fix comment
0b0fc0d
@bbalser
invalidate old bans if processing new ban
1a0138d
@bbalser
fix migration
bdca463
@bbalser
Fix naming after proto change
a772859
@bbalser
fix imports
0bdcab1
maplant
maplant approved these changes Jul 9, 2024
View reviewed changes
file_store/src/error.rs
@@ -8,7 +8,7 @@ pub enum Error {
Io(#[from] std::io::Error),
#[error("encode error")]
Encode(#[from] EncodeError),
#[error("dencode error")]
#[error("decode error")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked it better the old way

@bbalser bbalser merged commit ba2615e into main Jul 9, 2024
17 checks passed
@bbalser bbalser deleted the bbalser/hip-125 branch July 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymck andymck andymck left review comments

@maplant maplant maplant approved these changes

@michaeldjeffrey michaeldjeffrey michaeldjeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbalser @maplant @andymck @michaeldjeffrey