retry iot_config client rpcs #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
Aug 21, 2023
iot_config/src/client/mod.rs
Outdated
| Code::Cancelled | Code::DeadlineExceeded | Code::Unavailable => { | ||
| if attempt < 3 { | ||
| attempt += 1; | ||
| tokio::time::sleep(Duration::from_millis(attempt * 100)).await; |
There was a problem hiding this comment.
delay between attempts is very short. Doesnt give much time for any transitory issue to resolve
There was a problem hiding this comment.
@andymck What do you think it should be?
There was a problem hiding this comment.
We default the rpc timeout in the client endpoint builder to 5 sec already so it should probably be less then that since we’re making three calls but I can skip the increasing back off and just retry 3 times at the default. That reminds me though we’d talked about modifying the request to set the timeout header which is going to shoot this whole thing down
There was a problem hiding this comment.
Should we start with 1 second, so then do 1,2,3??
bbalser
approved these changes
Aug 21, 2023
andymck
approved these changes
Aug 21, 2023
maplant
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.