Make file_store usable outside of oracles #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
force-pushed
the
jg/file-store-refactor
branch
from
4b2c3f9
to
8be16aa
Compare
maplant
reviewed
Aug 8, 2023
file_store/src/file_store.rs
Outdated
| after: A, | ||
| before: B, | ||
| ) -> Result<Vec<FileInfo>> | ||
| where | ||
| F: Into<FileType> + Copy, | ||
| P: ToString + std::fmt::Display, |
There was a problem hiding this comment.
I believe this Display bound is unnecessary.
Generally, I would not suggest having things impl ToString, and instead just have the function take a &str
There was a problem hiding this comment.
addressed; i thought we had steered toward a slightly more permissive impl ToString and impl AsRef<str> but maybe i'm thinking of something else
andymck
approved these changes
Aug 9, 2023
bbalser
approved these changes
Aug 9, 2023
jeffgrunewald
force-pushed
the
jg/file-store-refactor
branch
from
b16023b
to
97dfb6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the internal FileInfo struct from file-store to have a generic "prefix" instead of an internally defined enum FileType to allow external apps/libraries that use file-store as a dependency to build FileInfos for their own types (when using for searching the S3 records for instance).
This is intended as a minimal refactor; a longer-term solution would be to implement a FileInfo trait that encapsulates the functionality in question and better exposes some common functionality used in the file store cli commands for extension (such as "listing" a collection of files into a stream, filtered by an input type and decoded)