Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Add support for rewards-v3 #1423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for rewards-v3 #1423

wants to merge 2 commits into from

Conversation

vihu
Copy link
Member

@vihu vihu commented Jul 11, 2022 •
edited
Loading

Summary

Add support for rewards_v3 transaction.

Notes

  • rewards_v3 transaction only rewards for consensus, securities and the remaining rewards go to a single treasury
  • Ensures all reward related chain vars are gathered once, this significantly simplifies rewards txn
  • Adds a basic test and checks whether the rewards are in within some (10 ^ -10) threshold of acceptance
  • Metadata for rewards is still exported along with some other potentially useful functions (get_reward_vars/3 for example)

TODO

  • Check whether aux ledger still works

@Vagabond
Copy link
Contributor

Seems reasonable

vihu added 2 commits July 18, 2022 14:47
@vihu
Add rewards_v3 transaction
6ec6e25 
- Add structure for rewards_v3 transaction
- Switch proto
- Ensure all reward related vars are gathered once
- Cleanup dialyzer
@vihu
Add rewards_v3 test
7b6f8de
@vihu vihu changed the title [DNM] Add support for rewards-v3 Add support for rewards-v3 Jul 18, 2022
@vihu vihu marked this pull request as ready for review July 18, 2022 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Vagabond Vagabond Vagabond left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vihu @Vagabond