Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for lens type classes #1

Open
tmcgilchrist opened this issue Jan 16, 2019 · 6 comments
Open

Adding support for lens type classes #1

tmcgilchrist opened this issue Jan 16, 2019 · 6 comments

Comments

@tmcgilchrist
Copy link

Would you consider adding or accepting a PR to add lens type class support?
eg Prism, Iso

@chessai
Copy link
Collaborator

chessai commented Jan 16, 2019

Yes, I would.

@andrewthad
Copy link
Collaborator

Laws for all lawful typeclasses are welcome so long as they come with a manual flag that can be used to disable their them (the flags are needed because primitive's test suite uses quickcheck-classes, and the extra deps would make travis take a long time).

@chessai
Copy link
Collaborator

chessai commented Jan 17, 2019

Yes, thanks for mentioning that @andrewthad. However I think you thought that this was quickcheck-classes when you made that comment.

The same does apply here though: All laws from typeclasses external to base need: a flag that toggled their status as a build dependency, a cpp-option "HAVE_${PACKAGENAME}", and for the library/test suite only to build the Laws/tests for the associated typeclass (using the CPP).

@andrewthad
Copy link
Collaborator

Yep, my bad. I was thinking of the wrong repo.

@kozross
Copy link

kozross commented Jun 3, 2020

It's be nice to have this for the optics versions too.

@jkachmar
Copy link
Contributor

It looks like there's a project that implements some hedeghog checkers for the optics library: https://github.com/typeclasses/hedgehog-optics/blob/master/hedgehog-optics/src/Hedgehog/Optics.hs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants