Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #490 #493

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for #490 #493

wants to merge 3 commits into from

Conversation

pbarron
Copy link
Contributor

@pbarron pbarron commented Jul 11, 2012

Fix for "NodeAutoDiscoverService discovering listen_address instead of rpc_address" Issue #490.

I have not got to try or test this yet but it should work.

@patricioe
Copy link
Collaborator

Thanks for the Patch. Nate, let's make sure we test it out before merging it.

@zznate
Copy link
Collaborator

zznate commented Jul 15, 2012

@pbarron have you had a chance to field this yet?

@pbarron
Copy link
Contributor Author

pbarron commented Jul 27, 2012

Sorry @zznate we've yet to do it.

@zznate
Copy link
Collaborator

zznate commented Jul 27, 2012

@pbarron No worries. Can you rebase and I'll test this? Thanks.

@zznate zznate closed this Aug 24, 2012
@zznate zznate reopened this Aug 24, 2012
@zznate
Copy link
Collaborator

zznate commented Aug 24, 2012

ping @pbarron did you guys field this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants