Add conffiles template support #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigafied
force-pushed
the
feature/conffiles
branch
2 times, most recently
from
b3115ac
to
ea9f16d
Compare
gigafied
force-pushed
the
feature/conffiles
branch
from
ea9f16d
to
e17a770
Compare
heartsucker
reviewed
Aug 20, 2018
| @@ -730,6 +747,8 @@ replace_vars() { | |||
| declare -r target_file="$2" | |||
| declare -r permissions="$3" | |||
|
|
|||
| lf=$'\n' | |||
There was a problem hiding this comment.
Why is lf being set here? Can you add a comment please.
There was a problem hiding this comment.
sed on macOS does not properly interpret \n in the replace pattern so we either need to do a literal line break (ugly) or assign \n to a var and do it that way.
|
Is this PR going to be accepted? I think it's a good idea (I need configurable conf files too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.