Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign a filler to __version__ if it cannot be imported #907

Merged
merged 4 commits into from
Jul 18, 2023
Merged

assign a filler to __version__ if it cannot be imported #907

merged 4 commits into from
Jul 18, 2023

Conversation

bendichter
Copy link
Contributor

Motivation

fix #905

@bendichter bendichter added the priority: critical impacts proper operation or use of core function of NWB or the software label Jul 18, 2023
@bendichter bendichter requested a review from rly July 18, 2023 02:38
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (19c56f6) 88.32% compared to head (9621bf6) 88.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #907   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          45       45           
  Lines        9274     9274           
  Branches     2649     2649           
=======================================
  Hits         8191     8191           
  Misses        765      765           
  Partials      318      318           
Impacted Files Coverage Δ
src/hdmf/__init__.py 61.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly
Copy link
Contributor

rly commented Jul 18, 2023

This works locally for me. MWE:

conda create --name test python=3.9 --yes
conda activate test
git checkout 3.6.0
pip install -e .
git checkout fix/905
python -c "import hdmf; print(hdmf.__version__)"

@rly rly merged commit bc10594 into dev Jul 18, 2023
26 checks passed
@rly rly deleted the fix/905 branch July 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: critical impacts proper operation or use of core function of NWB or the software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Import error in dev mode
3 participants