From e31f6a3d36b7d9653ce1bacbb8a2d3b86dd1e323 Mon Sep 17 00:00:00 2001 From: Oliver Ruebel Date: Sun, 1 Oct 2023 14:30:56 -0700 Subject: [PATCH] Fix #127 update paralle write test to set table ids (#128) * Fix #127 update paralle write test to set table ids * Update CHANGELOG --------- Co-authored-by: Matthew Avaylon --- CHANGELOG.md | 2 +- tests/unit/test_parallel_write.py | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 48e2cca3..63bc9402 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ * Enhanced ZarrIO to resolve object references lazily on read similar to HDMF's `HDF5IO` backend. @mavaylon1 [#120](https://github.com/hdmf-dev/hdmf-zarr/pull/120) ### New Features -* Added parallel write support for the ``ZarrIO`` for datasets wrapped with ``GenericDataChunkIterator``. @CodyCBakerPhD [#118](https://github.com/hdmf-dev/hdmf-zarr/pull/118) +* Added parallel write support for the ``ZarrIO`` for datasets wrapped with ``GenericDataChunkIterator``. @CodyCBakerPhD [#118](https://github.com/hdmf-dev/hdmf-zarr/pull/118) @oruebel [#128](https://github.com/hdmf-dev/hdmf-zarr/pull/128) ### Dependencies * Updated HDMF and PyNWB version to the most recent release @mavaylon1 [#120](https://github.com/hdmf-dev/hdmf-zarr/pull/120) diff --git a/tests/unit/test_parallel_write.py b/tests/unit/test_parallel_write.py index 61aae7ab..3bd3e08a 100644 --- a/tests/unit/test_parallel_write.py +++ b/tests/unit/test_parallel_write.py @@ -189,7 +189,12 @@ def test_simple_tqdm(tmpdir): display_progress=True, ) ) - dynamic_table = DynamicTable(name="TestTable", description="", columns=[column]) + dynamic_table = DynamicTable( + name="TestTable", + description="", + columns=[column], + id=list(range(3)) # must provide id's when all columns are iterators + ) io.write(container=dynamic_table, number_of_jobs=number_of_jobs) assert expected_desc in tqdm_out.getvalue() @@ -222,7 +227,10 @@ def test_compound_tqdm(tmpdir): ) ) dynamic_table = DynamicTable( - name="TestTable", description="", columns=[pickleable_column, not_pickleable_column] + name="TestTable", + description="", + columns=[pickleable_column, not_pickleable_column], + id=list(range(3)) # must provide id's when all columns are iterators ) io.write(container=dynamic_table, number_of_jobs=number_of_jobs)