-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facial Landmark Annotation #9
Comments
Think this will be covered by the points scheme I am working on, |
yes, thats why i assigned it to you :) |
I have just pushed my current version which should all this to work. Let me know if there is anything else that is needed for this. |
hey Thomas, i had a quick look at it, and it's already looking very promsing. Do you think you can handle merging it with the latest changes in the master branch? |
Think I should be able too. |
Hi guys, I have added additional functionality to the points, you can now delete points (set them back to -1,-1), move point/s using right click and mouse drag (uses the points selected in the list). I am having trouble merging the current master into my version as so much has changed and keep getting close but then finding I have removed something I shouldn't have. I have been using my local hotfixes branch to do this, by making it up today with master then merging the geometric branch in. Cheers, |
Hey Tom, |
Ok, fixed some minor issues (the annolist always changed and the video got small for any other annotation than points, the interface was not cleared properly). Please test the merge branch if everything is working as you would expect. I think this works pretty well already. Some issues we still should adress for points:
|
Thanks Tobi :D There are a few thing Michel wants as well,
The problem I found was when click play it doesn't display the current frame's points only the last selected so going to fix that. Will also keep this up to date when you push new update :) |
Updated with changes mentioned above. |
Johannes big merge is added to master, please branch from master for future development. He changed some parts of your code as well, so please check it out |
Has the recent point bug been fixed? and the others since 24th? |
yes should be, used the latest version from geometric |
can you check if everything is here? The code is in the MainHandlerGeometric now, and the painting is done a bit easier so zooming also works |
There are a few broken features, but I will look into this over the next few days. Liking the new layout though |
Hey Thomas, whats the intention that when you click the signal track it always jumps to the next annotation? On discrete and regular tiers, this is not the desired behaviour. Any reason this is done? (For now it requires the shift button to jump to the next label, otherwise it's back to the default behaviour). Maybe there is some reason i dont understand |
Hi,
I mean to add an if statement that only allows this for geometric or continuous.
It allows you to read the actual values from the tables.
Will add it in now ☺
Tom
|
Updated it, should stop interfering now :) |
having a look into it.. On other news it's now possible to store and load point annotations to the database. The bad thing is that they get pretty huge and mongodb has a limit of 16 mb. Will need to think of a solution for this. I made minor changes to the file format as (only the headers) so please update existing files, tjhats how they should look like (before the minscore was abused to hold the num_points ;) ) |
Liking the new file format for the points.
When I first started doing the geometric stuff I did think I should change it but wasn’t too familiar with the framework yet.
Quick question, I am trying to initialise the segmentation values in AnnoTier.cs and I need the width and height of the video but struggling to find a way of getting it.
Thanks for looking into the sync issue.
|
A nice addition would be to visualize and edit facial landmarks in a video. How exactly is up for discussion
The text was updated successfully, but these errors were encountered: